search

singer-io / tap-taboola

A Singer tap for extracting data from the Taboola API
GNU Affero General Public License v3.0
2 stars 12 forks source link

Group accounts not supported #6

Open Joe-Heffer-MPE opened 5 years ago

Joe-Heffer-MPE commented 5 years ago

Hi,

At the moment, our Taboola Stitch integration returns 0 rows for the campaigns table.

I believe this is because, for our Taboola API access, our client ID is associated with a "GROUP" type account, which is an umbrella account containing multiple "normal" advertiser accounts.

Please could we make it so that this tap connects to "all allowed accounts" and retrieves all campaign objects and campaign performance reports?

This is done by calling the users/current/allowed-accounts/ endpoint which gives each account in the following form, as a list in the results attribute of the returned object:

{'account_id': 'mycompany-group',
 'campaign_types': ['PAID'],
 'id': 1234,
 'name': 'My Company - Group',
 'partner_types': None,
 'type': 'GROUP'}

{'account_id': 'my-taboola-account',
 'campaign_types': ['PAID'],
 'id': 1235,
 'name': 'My Taboola Advertiser Account',
 'partner_types': ['ADVERTISER'],
 'type': 'PARTNER'}

I have written Python code to do this but I'd like to include this in this tap.

EnderFrias commented 5 years ago

Hi @Joe-Heffer-MPE

Any luck with implementing this? have you tried just creating pull request with your changes?

Joe-Heffer-MPE commented 5 years ago

Hi @Joe-Heffer-MPE

Any luck with implementing this? have you tried just creating pull request with your changes?

I haven't, but I'll add it to my to-do list.

Joe-Heffer-MPE commented 5 years ago

I've made a pull request to address this issue: https://github.com/singer-io/tap-taboola/pull/7

sturgesr commented 4 years ago

Hey @Joe-Heffer-MPE

I see that you have created the pull request for this change. Do you know if this is something that is going to be updated? If not, did you come up with a work around?