search

singer-io / tap-typeform

Singer.io tap for extracting TypeForm data
GNU Affero General Public License v3.0
11 stars 20 forks source link

Correct bookmarked date (#9) #11

Closed flpezet closed 4 years ago

flpezet commented 4 years ago

Misbehavior Say I set incremental_range = 'daily'. If the tap is run at 8:AM, all the answers and landings between midnight and 8:AM will be retrieved. An attempt to get data after 8:AM will be made with obviously no returned data.

The next job will have its date_to_resume set to the next day at midnight. So the next jobs won't retrieve the data after 8:AM. The resulting problem can be seen in #9 .

This PR aims at preventing date_to_resume to be higher than end_date.

cmerrick commented 4 years ago

Hi @flpezet, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 4 years ago

You did it @flpezet!

Thank you for signing the Singer Contribution License Agreement.

jennygibbons commented 4 years ago

Hi @flpezet and @cmerrick - I am wondering if there is any update on this? We are running into the same problem and it seems like this would fix it.

Thanks!

flpezet commented 4 years ago

Andy Lu has started to give me feedback on the PR via Singer Slack. I'm waiting for the next iteration. Can't give you any ETA... :/ @luandy64 is it possible for you to review the PR? It seems to be a very eagerly awaited bug fix. If I can do anything to speed up the review process, let me know! :)

kingfink commented 4 years ago

@flpezet @luandy64 any chance of a review on this or an update on the ETA?

Happy to do anything I can to accelerate the process.