Closed kingfink closed 4 years ago
Hi @kingfink, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @kingfink!
Thank you for signing the Singer Contribution License Agreement.
Description of change
Updated the bookmarked date for TypeForm so that recent responses are captured without requiring a full resync.
Also made an update so that the default end date will not be in the past.
Manual QA steps
First, I ran the existing tap:
I saved the output
STATE
message:Then, I submitted a new form response on 12/12 at 18:35 UTC and tried to pick-up where I left off based on that
state.json
and no results were returned.Now, trying with this fork:
I saved the output of the new
STATE
message and then submitted another new response on 12/12.Running again and successfully getting the new response:
Finally, testing along with
target-csv
and verifying the files generated(answers-*.csv
,landings-*.csv
,questions-*.csv
) contained the correct information.Risks
Rollback steps