singer-io / tap-typeform

Singer.io tap for extracting TypeForm data
GNU Affero General Public License v3.0
11 stars 20 forks source link

Handle empty forms #23

Closed DaMaillard closed 3 years ago

DaMaillard commented 4 years ago

If a form is empty, this line will raise an exception. The problem is that this exception will fail the extraction for all the (non-empty) forms, and so break the replication.

Description of change

Handle empty forms

Manual QA steps

Risks

Rollback steps

cmerrick commented 4 years ago

Hi @DaMaillard, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 4 years ago

You did it @DaMaillard!

Thank you for signing the Singer Contribution License Agreement.

DaMaillard commented 4 years ago

Hello, Do you need some clarifications or something to review this PR ? The changes are relatively small but can bring some value, so we can progress quickly on this if you don't need any additional elements.

cc @luandy64 @cmerrick

DaMaillard commented 4 years ago

Hello ! :) Any update on this ?

ericalouie commented 4 years ago

@cmerrick Is there any update on this? I'm also experiencing the same issue on my end and this PR would definitely help! (thanks @DaMaillard for your contribution!)

fhinson commented 4 years ago

@cmerrick / @luandy64 any update on this? thank you

fhinson commented 3 years ago

@nmccormick-bombas can you get another reviewer to approve?

nmccormick-bombas commented 3 years ago

@ericalouie can you approve so we can merge? :)

fhinson commented 3 years ago

thanks @ericalouie, there seems to be an issue with the ci build however

Nicarim commented 3 years ago

I'm having trouble using this script and this pull request would really help get the problem fixed!

pkoltermann commented 3 years ago

Without this merged I'm not able to use @stitchdata :(