Closed DaMaillard closed 3 years ago
Hi @DaMaillard, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @DaMaillard!
Thank you for signing the Singer Contribution License Agreement.
Hello, Do you need some clarifications or something to review this PR ? The changes are relatively small but can bring some value, so we can progress quickly on this if you don't need any additional elements.
cc @luandy64 @cmerrick
Hello ! :) Any update on this ?
@cmerrick Is there any update on this? I'm also experiencing the same issue on my end and this PR would definitely help! (thanks @DaMaillard for your contribution!)
@cmerrick / @luandy64 any update on this? thank you
@nmccormick-bombas can you get another reviewer to approve?
@ericalouie can you approve so we can merge? :)
thanks @ericalouie, there seems to be an issue with the ci build however
I'm having trouble using this script and this pull request would really help get the problem fixed!
Without this merged I'm not able to use @stitchdata :(
If a form is empty, this line will raise an exception. The problem is that this exception will fail the extraction for all the (non-empty) forms, and so break the replication.
Description of change
Handle empty forms
Manual QA steps
Risks
Rollback steps