singer-io / tap-typeform

Singer.io tap for extracting TypeForm data
GNU Affero General Public License v3.0
11 stars 20 forks source link

Support subquestions #35

Open ChrisCoffey opened 3 years ago

ChrisCoffey commented 3 years ago

Description of change

We've encountered the issue described in https://github.com/singer-io/tap-typeform/issues/13. The problem is that Typeform groups aren't actually questions. They're actually wrappers around lists of questions, so need to be parsed differently from other fields.

Here's an example of the group response from Typeform's field definition:

,
        {
            "id": "t74tqzY6gpow",
            "properties": {
                "button_text": "Continue",
                "fields": [
                    {
                        "id": "ne0ti8xNbxQo",
                        "properties": { 
                        ...
                        },
                        "ref": "21b08fa6-9e91-4e55-9b99-c646b058d246",
                        "title": "What was the first college you applied to?",
                        "type": "dropdown",
                        "validations": {
                            "required": true
                        }
                    },
                    ...
                ],
                "show_button": true
            },
            "ref": "59905e57-02a5-4e4e-b392-6292a52f1309",
            "title": "In this next section, we need some more information about the colleges that you applied to.",
            "type": "group"
        },

Note that each sub-field within the group has id, ref, and title, so they'll parse fine.

What is the best way to test this change?

cmerrick commented 3 years ago

Hi @ChrisCoffey, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 3 years ago

You did it @ChrisCoffey!

Thank you for signing the Singer Contribution License Agreement.

ChrisCoffey commented 3 years ago

@pbegle Do you have any advice for testing this change?

kjarrith commented 3 years ago

Any status on this?

maruskya commented 2 years ago

@cmerrick is there any status update on this PR?