singer-io / tap-typeform

Singer.io tap for extracting TypeForm data
GNU Affero General Public License v3.0
11 stars 20 forks source link

feat(submitted_landings): add tags property #68

Closed MuriloKakazu closed 11 months ago

MuriloKakazu commented 1 year ago

Description of change

Add the tags property to submitted_landings.

Tags are used in typeform to categorize responses (ref) so I think it's useful data for the tap to extract.

Manual QA steps

Tested using target-json as a target for this tap:

tap-typeform --config config.json --catalog catalog.json | ~/.virtualenvs/target-json/bin/target-json

You can add tags to some responses following these steps and then run the tap. The resulting tags property will either be an array of strings (e.g ['myTag', 'myOtherTag']) or an empty array ([]) if it has no tags.

Risks

None that I could think of.

Rollback steps

singer-bot commented 1 year ago

Hi @MuriloKakazu, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

singer-bot commented 1 year ago

You did it @MuriloKakazu!

Thank you for signing the Singer Contribution License Agreement.

MuriloKakazu commented 1 year ago

@luandy64 @Vi6hal @kethan1122 @prijendev

(sorry on the mention. But I cant add people as reviewers and there's no code owners either 😛)

MuriloKakazu commented 1 year ago

@rdeshmukh15 can you review this one as well please? 😄

kethan1122 commented 1 year ago

@MuriloKakazu can u please merge your branch with master ?