singer-io / tap-typeform

Singer.io tap for extracting TypeForm data
GNU Affero General Public License v3.0
11 stars 20 forks source link

sync all forms when config not provided #72

Closed aaronbannin closed 1 year ago

aaronbannin commented 1 year ago

Description of change

If no form IDs provided in config, sync all forms.

Currently, the tap only syncs data for forms that are explicitly declared within the config. This is fine for accounts with a low number of forms; but is unable to pull data automatically from an active Typeform account.

If the forms config value is null or '', sync data for all known forms.

Improves stability in two ways:

This change is backwards compatible.

Manual QA steps

Tested against live Typeform account.

Risks

Rollback steps

singer-bot commented 1 year ago

Hi @aaronbannin, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

singer-bot commented 1 year ago

You did it @aaronbannin!

Thank you for signing the Singer Contribution License Agreement.

kethan1122 commented 1 year ago

Hello @aaronbannin. we are about to review this PR, any reason for closing this PR

aaronbannin commented 1 year ago

Sorry; I disconnected the upstream fork and didn't realize that it would close the PR. What would be the best way to proceed, I can try to create a new fork? Or someone else could create a new PR with these changes?

kethan1122 commented 1 year ago

No worries, We have created a new PR based on your changes. Please, have a look at this PR in-case we missed something.