Closed aaronbannin closed 1 year ago
Hi @aaronbannin, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @aaronbannin!
Thank you for signing the Singer Contribution License Agreement.
Hello @aaronbannin. we are about to review this PR, any reason for closing this PR
Sorry; I disconnected the upstream fork and didn't realize that it would close the PR. What would be the best way to proceed, I can try to create a new fork? Or someone else could create a new PR with these changes?
No worries, We have created a new PR based on your changes. Please, have a look at this PR in-case we missed something.
Description of change
If no form IDs provided in config, sync all forms.
Currently, the tap only syncs data for forms that are explicitly declared within the config. This is fine for accounts with a low number of forms; but is unable to pull data automatically from an active Typeform account.
If the
forms
config value isnull
or''
, sync data for all known forms.Improves stability in two ways:
This change is backwards compatible.
config.forms
value is set tonull
or''
Manual QA steps
Tested against live Typeform account.
config.json
;forms: null
config.json
;forms:""
config.json
;forms:"validFormId"
Risks
Rollback steps