singer-io / tap-zendesk-chat

A Singer.io tap to extract data from the Zendesk Chat API
GNU Affero General Public License v3.0
5 stars 18 forks source link

Schema change on shortcuts table #22

Open cgilj opened 4 years ago

cgilj commented 4 years ago

While trying to run an extraction, the job failed in the following way

Error persisting data to Stitch: 400: {'error': 'Record 714 for table shortcuts did not conform to schema:\n#: #: no subschema matched out of the total 2 subschemas\n#: expected: null, found: JSONObject\n#: extraneous key [agents] is not permitted\n'}

Checking the error message and Zendesk Chat API, seems that there's a new field agents on shortcuts table which does not exist on the current schema.

I saw an issue was opened some time ago for this same reason

https://github.com/singer-io/tap-zendesk-chat/issues/15

However, the fix does not seem to include an agents item on shortcuts schema, but a scope item on agents schema (which does not actually exist on Zendesk Chat API). Might there have been some confusion?

https://github.com/singer-io/tap-zendesk-chat/pull/16

Zendesk Chat API Docs

Screenshot from 2020-03-03 13-02-44

Current tap schema

https://github.com/singer-io/tap-zendesk-chat/blob/master/tap_zendesk_chat/schemas/shortcuts.json

I believe we would need to add something like

"agents": {
      "type": [
        "null",
        "array"
      ]
    },

Please let me know if this sounds accurate and if I can open a Pull Request myself to fix the issue. Thank you very much!

nickjl commented 4 years ago

hey @cgilj

did you get any further with this? running into same error and getting shortcuts out of zendesk is a nightmare! do you have any work around?

thanks 😁

katered8 commented 4 years ago

im also getting this error on every run ☹️ any updates?