singer-io / tap-zendesk

GNU Affero General Public License v3.0

16 stars 39 forks source link

add missing type definitions #114

Closed leo-schick closed 1 year ago

leo-schick commented 2 years ago

Description of change

Fix a missing type definition for:

stream tickets path custom_fields/*/value (this replaces PR #30)
stream sla_policies path policy_metrics/*/metric

Manual QA steps

run tap manually

Risks

breaking schema validation when type changes in the future in the API

Rollback steps

revert this branch

singer-bot commented 2 years ago

Hi @leo-schick, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

singer-bot commented 2 years ago

You did it @leo-schick!

Thank you for signing the Singer Contribution License Agreement.

leo-schick commented 1 year ago

This has now been untouched over long time and we moved away to airbyte. Will close this PR.