search

singer-io / tap-zendesk

GNU Affero General Public License v3.0
16 stars 39 forks source link

Update CUSTOM_TYPES to include lookup field #124

Open lukas-gust opened 1 year ago

lukas-gust commented 1 year ago

Description of change

This PR adds the lookup custom type to the CUSTOM_TYPES lookup. Lookups are references to other zendesk resources so their values are integers.

https://support.zendesk.com/hc/en-us/articles/4552827736218-Announcing-lookup-relationship-fields-for-Support https://support.zendesk.com/hc/en-us/articles/4591924111770#topic_wny_w3k_5tb

Relates to #117

https://jira.talendforge.org/browse/TDL-22790

Manual QA steps

Risks

Rollback steps

lukas-gust commented 1 year ago

Additional resources about zendesk lookups

https://developer.zendesk.com/documentation/ticketing/using-the-zendesk-api/retrieving-lookup-relationship-fields-with-the-api/

dan-ladd commented 1 year ago

Thanks @lukas-gust, we started recently running into this issue too and your PR looks good to me. Hoping someone can review and merge?

@JYOTHINARAYANSETTY , you've been on a tear recently with tap-zendesk. Thank you! Would you be able to look at this small PR? Thanks!