Vi6hal commented 12 months ago

Description of change

Manual QA steps

Why interger type for lookup fields and not string Ans: here

Co-author - @lukas-gust

Vi6hal commented 12 months ago

Can you add the new field to the all_fields test?

This is not exactly a new field, but rather a custom field type, and I have setup lookup fields on few streams to validate lookup datatype.

I was thinking to add a new test case for the following reason:

This type of field is not available on the UI for selection (being a nested field) although the parent object is available for selection
all_fields_test only covers the fields in the root hierarchy of the object and does not cover nested fields/schema
the location of lookup fields varies for streams, hence its preferable to validate it separately.

@cosimon what are your thoughts about adding a new test?

lukas-gust commented 12 months ago

Let me know if I can be of any assistance.

Vi6hal commented 11 months ago

Let me know if I can be of any assistance.

I have made some changes as suggested, once the team reviews and approves this change, i will merge this P.R.