search

singer-io / tap-zoom

GNU Affero General Public License v3.0
4 stars 16 forks source link

fixed passing webinar id to children of webinars endpoints #12

Open kurtcanm opened 2 years ago

kurtcanm commented 2 years ago

Description of change

When Zoom API endpoints of webinar_poll_results, webinar_qna_results, webinar_files, and webinar_absentees are queried by _webinar_uuid, the API returns "Meeting does not exist"_ as a response. Thus, these resources cannot be extracted via tapzoom. These endpoints must be queried by webinar_id_.

In endpoint.py, webinars node passes its uiid field as _webinaruuid to the children nodes. In order to fix the issue, the id field of webinars is provided as _webinaruuid instead of uuid.

Manual QA steps

*

Risks

*

Rollback steps

cmerrick commented 2 years ago

Hi @kurtcanm, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 2 years ago

You did it @kurtcanm!

Thank you for signing the Singer Contribution License Agreement.

rdeshmukh15 commented 1 year ago

As per the zoom API doc, to extract the data for webinar_poll_results, webinar_qna_results, webinar_files, and webinar_absentees API endpoints, it is still referring WebinarUUID