singer-io / tap-zoom

GNU Affero General Public License v3.0
4 stars 16 forks source link

Use next_page_token to fix zoom tap pagination #13

Open GJmelody opened 1 year ago

GJmelody commented 1 year ago

Description of change

page_number is a deprecated API param and is not being used now. Zoom doesn't take this param so it always only gets the results from the first page. To fix this issue we should use next_page_token instead based on Zoom document

image

Manual QA steps

Risks

Rollback steps

rdeshmukh15 commented 1 year ago

It is observed that on Zoom API doc for below API endpoints :

  1. 'meetings/{meeting_id}/registrants'
  2. '/webinars/{webinarId}/registrants'

It is mentioned that _pagenumber will be deprecated in next release and start using _next_pagetoken.

Screenshot 2023-03-30 at 11 53 15 PM

But as the per the postman response, we don't get the _next_pagetoken in the response. Hence, this change cannot be made at the moment. Attaching the part of postman response here :

PR-13-analysis

For _listmeetings (/users/{userId}/meetings), it is observed that _next_pagetoken is mentioned in the API doc but in actual response, it is not appearing.