singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.59k stars 837 forks source link

Wired behavior when Input with chinese keyboard on iphone #1723

Open mny459 opened 9 months ago

mny459 commented 9 months ago

Is there an existing issue for this?

Flutter Quill version

9.2.11

Steps to reproduce

  1. Open editor
  2. Try to input chinese by input two j

Expected results

Show 2 j

Actual results

Show 6 j

Code sample

Code sample ```dart QuillEditor( key: const ValueKey('editor'), scrollController: ScrollController(), focusNode: _focusNode, configurations: QuillEditorConfigurations( controller: _contentController, embedBuilders: FlutterQuillEmbeds.defaultEditorBuilders(), sharedConfigurations: QuillSharedConfigurations( locale: Localizations.localeOf(context), ), padding: const EdgeInsets.symmetric(horizontal: 24, vertical: 10), minHeight: 200, readOnly: false, expands: false, scrollable: true, autoFocus: PlatformHelper.isDesktop(), showCursor: true, enableInteractiveSelection: true, enableSelectionToolbar: true, scrollBottomInset: 12, customStyles: QuillHelper.defaultStyles( context, themeColor.onBackgroundColor, font, ), onTapUp: (_, __) { _focusNode.requestFocus(); return false; }, onLaunchUrl: (url) => NavigationHelper.navWebView(url), ), ) ```

Screenshots or Video

Screenshots / Video demonstration You could hear I just tap j twice by keyboard sound [[Upload media here]](https://github.com/singerdmx/flutter-quill/assets/24559456/6cc82dab-304c-4ee9-8e01-e35c1e254cc6)

Logs

Logs ```console [Paste your logs here] ```
mny459 commented 9 months ago

back to 8.6.2 works fine

suntianjun commented 9 months ago

https://github.com/singerdmx/flutter-quill/assets/18193399/710e6346-c104-4fa2-bc4a-418dd5e8a054

same to you...

EchoEllet commented 9 months ago

back to 8.6.2 works fine

Are you sure? I don't think we have done any changes to the keyboard input in 9.0.0

mny459 commented 9 months ago

back to 8.6.2 works fine

Are you sure? I don't think we have done any changes to the keyboard input in 9.0.0

Yes, me and My app users verified.

suntianjun commented 9 months ago

9.2.5 works well, 9.2.6 bug occurs

EchoEllet commented 9 months ago

9.2.5 works well, 9.2.6 bug occurs

Please check this We haven't change much so I'm not sure if it's related to the changes we made

suntianjun commented 9 months ago

9.2.5 works well, 9.2.6 bug occurs

Please check this We haven't change much so I'm not sure if it's related to the changes we made

I checked, below is the broken changes :

lib/src/widgets/raw_editor/raw_editor_state_text_input_client_mixin.dart

EchoEllet commented 9 months ago

9.2.5 works well, 9.2.6 bug occurs

Please check this We haven't change much so I'm not sure if it's related to the changes we made

I checked, below is the broken changes :

lib/src/widgets/raw_editor/raw_editor_state_text_input_client_mixin.dart

  • value.selection,
  • value.selection.copyWith(
  • affinity: widget.configurations.controller.selection.affinity),

Can you revert locally and try our and see if it is still not working?

suntianjun commented 9 months ago

9.2.5 works well, 9.2.6 bug occurs

Please check this We haven't change much so I'm not sure if it's related to the changes we made

I checked, below is the broken changes : lib/src/widgets/raw_editor/raw_editor_state_text_input_client_mixin.dart

  • value.selection,

  • value.selection.copyWith(

  • affinity: widget.configurations.controller.selection.affinity),

Can you revert locally and try our and see if it is still not working?

I revert to 9.2.5 and it's fine, then I replace above code locally and not working, so the part code committed in 9.2.6 have problems.

EchoEllet commented 8 months ago

Can you check the latest master branch? I just reverted the change of the PR since I didn't get any response

hnvn commented 7 months ago

I still got this problem in version 9.3.3

https://github.com/singerdmx/flutter-quill/assets/5468513/99dedbb5-1e33-4b64-a10f-ea9609c024a8

EgorK0rshun commented 5 months ago

in 9.3.21 is also reproduced. Need a fix cc @ellet0