search

singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.58k stars 836 forks source link

Paste context menu not dismissed #2153

Open AtlasAutocode opened 2 months ago

AtlasAutocode commented 2 months ago

Is there an existing issue for this?

Flutter Quill version

10.4.4

Steps to reproduce

Use the example app and run on mobile. Long press to select a word, get popup menu and select Copy. Popup menu is dismissed. Long press at a different place, get popup menu and select Paste. Text is pasted but the popup menu is NOT dismissed.

This issue was fixed in PR2116 These changes were removed in PR2128 to address the problem with the magnifier.

Expected results

Popup menu should be dismissed after paste is selected.

Actual results

Popup menu is still present after paste is selected.

Code sample

Code sample ```dart [Paste your code here] ```

Additional Context

Screenshots / Video demonstration [Upload media here]
Logs ```console [Paste your logs here] ```
AtlasAutocode commented 2 months ago

@demoYang and @CatHood0 can you take a look at this problem? These changes appear to be mutually exclusive. I regret that I do not understand mobile enough to be able to figure out what is going on.

CatHood0 commented 2 months ago

I know what part is causing the error. I'll test my fix soon (i don't know why it was removed)

AtlasAutocode commented 2 months ago

@CatHood0 your changes fixed the paste problem. I assume @demoYang made the changes because it was needed to fix the problem with the magnifier.

However, when I re-introduced your changes, it caused even more problems. So, I think there is some deeper conflict between paste popup and magnifier.

CatHood0 commented 2 months ago

However, when I re-introduced your changes, it caused even more problems.

I don't expect that. It's weird. You have a point, it could be something more deeper than we expect.

CatHood0 commented 1 month ago

Does this issue still persists? If not we need to close it.

EchoEllet commented 1 month ago

@AtlasAutocode

Is this still an issue?

AtlasAutocode commented 1 month ago

Yes, still exists. I haven't had time to look into it since I almost never use mobile and know nothing about how such popups are managed. It's an obvious bug but not critical. Feel free to close this issue.

EchoEllet commented 1 month ago

Will keep it open, since we don't add new features anymore, we should have more time but for now, we're focusing on other issues.