Provide default native implementation of ClipboardService without external dependencies

EchoEllet commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Use case

The functionality of Flutter Clipboard is limited and only supports retrieving the content as plain text since the implementation can be different on each platform, there is no standard.

This leads us to use plugins for accessing the platform APIs we need for some features, such as rich text pasting, which allows the user to copy content from websites and apps and paste them into the editor, with the links, styles, etc...

Why replace `pasteboard` with `super_clipboard`?

Previously, we were using pasteboard for accessing the clipboard, I had to replace it with super_clipboard since it lacks support for Android (for all methods), and not all functions support all platforms, the static getter html only supports Windows and Web and it doesn't seem to work on Web either since web require registering the paste event. It also was a bit outdated (2y since the last update on pub.dev), it has been updated recently (8 days ago) to support Flutter/WASM.

Why moved `super_clipboard`to `flutter_quill_extensions`?

super_clipboard uses Rust to access platform APIs and a bridge, which seems to be experimental and caused a lot of build failure issues for a lot of users, some of the issues are in runtime and are unexpected, I have tried it out on Linux and macOS without any issues other than it takes long to build the app for the first time. So we had to exclude it from flutter_quill and move it to flutter_quill_extensions, which also requires calling a function manually to use the plugin implementation.

It also requires minSdkVersion to be at least 23 which seems to be an issue since some apps still use 19 or 21.

See #1914 for more details.

Why move `super_clipboard` into its own package/module?

I initially wanted to move super_clipboard into its own package (quill_super_clipboard) to allow flutter_quill users to use it without flutter_quill_extensions and users of flutter_quill_extensions to use the extensions package without super_clipbaord. We were interested in having fewer dependencies on the user's project.

Since those issues still persist, we will introduce a breaking change and move the super_clipboard outside of flutter_quill_extensions.

What about `rich_clipboard`?

It has been discontinued.

What would be the replacement?

As a replacement, we will provide a default native implementation for the functionalities we need instead of relying on third-party plugins. We have introduced quill_native_bridge in #2194 and removed device_info_plus to have more control over the implementation, only the functionalities we need which result in a more lightweight package, and fewer issues and conflicts with the user dependencies if a major breaking release introduced in a dependency, you can update directly without having to update the Flutter Quill project first, when a new feature comes out in Flutter, like a major breaking release such as support for Flutter/WASM or breaking changes in Dart or updating Android Gradle Plugin, we can update the project directly from this repo.

If we manage to get this feature working on all platforms, you probably won't need pasteboard or super_clipboard for this feature anymore.

We only need a way to access the HTML and Markdown from the system clipboard (regardless if it was a file or a text copied from an app or website).

Web

we have already introduced support for this feature in #2009 using paste_event,. There seems to be an issue, see #2220.

Clipboard API has restrictions on Firefox and Safari.

Screenshot

![image](https://github.com/user-attachments/assets/1e61addf-208c-4e04-a76d-955c9727d991)

Web support of rich text pasting is missing (need to solve #2220).

EchoEllet commented 2 months ago

@CatHood0 Not related to this issue but can you take a look at this issue when you have the time?

Issue Details

Select and copy the following from issue #2009 (an example): ![image](https://github.com/user-attachments/assets/06a92f8c-e762-4306-875d-3de72f8f3997) Paste it into the editor in the example and you will have this error (on macOS) ```console [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Invalid argument(s): color format not supported: var(--fgColor-muted, var(--color-fg-muted)) #0 colorToHex (package:flutter_quill_delta_from_html/parser/colors.dart:56:5) colors.dart:56 #1 validateAndGetColor (package:flutter_quill_delta_from_html/parser/colors.dart:22:10) colors.dart:22 #2 parseStyleAttribute (package:flutter_quill_delta_from_html/parser/html_utils.dart:54:25) html_utils.dart:54 #3 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:60:13) node_processor.dart:60 #4 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) node_processor.dart:123 #5 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) node_processor.dart:123 #6 HtmlOperations.resolveCurrentElement (package:flutter_quill_delta_from_html/parser/html_to_operation.dart:44:9) html_to_operation.dart:44 #7 DefaultHtmlToOperations.listToOp (package:flutter_quill_delta_from_html/parser/default_html_to_ops.dart:219:22) default_html_to_ops.dart:219 #8 HtmlOperations.resolveCurrentElement (package:flutter_quill_delta_from_html/parser/html_to_operation.dart:52:36) html_to_operation.dart:52 #9 HtmlToDelta.nodeToOperation (package:flutter_quill_delta_from_html/parser/html_to_delta.dart:222:38) html_to_delta.dart:222 #10 HtmlToDelta.convert (package:flutter_quill_delta_from_html/parser/html_to_delta.dart:129:42) html_to_delta.dart:129 #11 DeltaX.fromHtml (package:flutter_quill/src/delta/delta_x.dart:50:24) delta_x.dart:50 #12 QuillControllerRichPaste.pasteHTML (package:flutter_quill/src/controller/quill_controller_rich_paste.dart:40:41) quill_controller_rich_paste.dart:40 #13 QuillController.clipboardPaste (package:flutter_quill/src/controller/quill_controller.dart:577:35) quill_controller.dart:577 #14 QuillRawEditorState.pasteText (package:flutter_quill/src/editor/raw_editor/raw_editor_state.dart:147:9) raw_editor_state.dart:147 ``` On iOS: ```console Connecting to VM Service at ws://127.0.0.1:57100/B_FJsvoNFPU=/ws Connected to the VM Service. [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Invalid argument(s): color format not supported: var(--fgColor-muted, var(--color-fg-muted)) #0 colorToHex (package:flutter_quill_delta_from_html/parser/colors.dart:56:5) colors.dart:56 #1 validateAndGetColor (package:flutter_quill_delta_from_html/parser/colors.dart:22:10) colors.dart:22 #2 parseStyleAttribute (package:flutter_quill_delta_from_html/parser/html_utils.dart:54:25) html_utils.dart:54 #3 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:60:13) node_processor.dart:60 #4 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) node_processor.dart:123 #5 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) node_processor.dart:123 #6 HtmlOperations.resolveCurrentElement (package:flutter_quill_delta_from_html/parser/html_to_operation.dart:44:9) html_to_operation.dart:44 #7 DefaultHtmlToOperations.listToOp (package:flutter_quill_delta_from_html/parser/default_html_to_ops.dart:219:22) default_html_to_ops.dart:219 #8 HtmlOperations.resolveCurrentElement (package:flut<…> ``` Same issue on Android: ```console Unhandled Exception: Invalid argument(s): color format not supported: var(--textTertiary) E/flutter (29830): #0 colorToHex (package:flutter_quill_delta_from_html/parser/colors.dart:56:5) E/flutter (29830): #1 validateAndGetColor (package:flutter_quill_delta_from_html/parser/colors.dart:22:10) E/flutter (29830): #2 parseStyleAttribute (package:flutter_quill_delta_from_html/parser/html_utils.dart:54:25) E/flutter (29830): #3 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:60:13) E/flutter (29830): #4 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) E/flutter (29830): #5 processNode (package:flutter_quill_delta_from_html/parser/node_processor.dart:123:7) E/flutter (29830): #6 HtmlOperations.resolveCurrentElement (package:flutter_quill_delta_from_html/parser/html_to_operation.dart:44:9) E/flutter (29830): #7 DefaultHtmlToOperations.listToOp (package:flutter_quill_delta_from_html/parser/default_html_to_ops.dart:219:22) E/flutter (29830): #8 HtmlOperations.resolveCurrentElement (package:flutter_quill_delta_from_html/parser/html_to_operation.dart:52:36) E/flutter (29830): #9 HtmlToDelta.nodeToOperation (package:flutter_quill_delta_from_html/parser/html_to_delta.dart:222:38) E/flutter (29830): #10 HtmlToDelta.convert (package:flutter_quill_delta_from_html/parser/html_to_delta.dart:129:42) E/flutter (29830): #11 DeltaX.fromHtml (package:flutter_quill/src/delta/delta_x.dart:50:24) E/flutter (29830): #12 QuillControllerRichPaste.pasteHTML (package:flutter_quill/src/controller/quill_controller_rich_paste.dart:40:41) E/flutter (29830): E/flutter (29830): #13 QuillController.clipboardPaste (package:flutter_quill/src/controller/quill_controller.dart:577:35) E/flutter (29830): E/flutter (29830): #14 QuillRawEditorState.pasteText (package:flutter_quill/src/editor/raw_editor/raw_editor_state.dart:147:9) E/flutter (29830): E/flutter (29830): ``` > For this case, it doesn't seems to be an issue on one specific platform however the HTML content can be very platform-dependent, and not everything can be validated, some attributes need to be ignored without throwing an error, throwing an error is suitable when reading or parsing the HTML to load it as a document. the parsing process itself should not be slightly different based on the platform regardless of the issue. We might need to have a separate implementation specifically for pasting HTML content into the editor in `flutter_quill`, especially if fixing this issue affects the users of [`flutter_quill_delta_from_html`](https://pub.dev/packages/flutter_quill_delta_from_html) who are using the package for a little bit different purpose.

CatHood0 commented 2 months ago

@EchoEllet Thanks for reporting it. Must be an issue with how the package transform the colors from html to a color valid for Delta. I'll fix it soon.

CatHood0 commented 2 months ago

We might need to have a separate implementation specifically for pasting HTML content into the editor

Are you suggesting to have a class that allows us to get the appropriate Delta without directly using the flutter_quill_delta_from_html package? Maybe doing this would allow us to have any other implementation later without having to remove almost any code and we can control any exception from that class.

EchoEllet commented 2 months ago

It's probably what I'm suggesting. We can rewrite the fromHtml specifically and only for this rich pasting feature, or maybe extract the needed parts from flutter_quill_delta_from_html and modify it to adjust the needs, we could also have slightly different implementation in flutter_quill_delta_from_html by having a separate class or provide an option in the package to check if what we want is to paste this Delta into the editor, and then will change the conversation process to fit.

Similarly, how vsc_quill_delta_to_html handle it:

final converter = QuillDeltaToHtmlConverter(
    ops,
    ConverterOptions.forEmail(),
  );

We should have more consideration before making this change. Is this something only needed for flutter_quill or more users interested in this feature?

Meanwhile, I think we're okay with fixing this color parsing issue above. This shouldn't be a high priority issue.

CatHood0 commented 2 months ago

Not related to this issue but can you take a look at this issue when you have the time?

This should be fixed already with the new version.

singerdmx / flutter-quill