singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.6k stars 839 forks source link

Bug fix: Removing check not allowing spell check on web #2252

Closed joeserhtf closed 2 months ago

joeserhtf commented 2 months ago

Description

Fix: Enable spell check for Web.

For some reason, this call was locked for web builds. Removing this lock, and running multiple tests without problems. Using the spell check package adds a lot to the size, but it's not a problem.

Related Issues

Found: https://github.com/singerdmx/flutter-quill/issues/2164

Type of Change

EchoEllet commented 2 months ago

Thank you for your contributions. If you do plan on using Spell Checker in your own app, please take a look at #2246 first. We do plan on breaking the SpellCheckerService completely soon to fix some issues. Which is the main reason I moved it into the example instead of own package. It will be experimental even after those changes.

@singerdmx I will review this change soon.

@CatHood0 Is this a reason for this check, or maybe it's for preventing an issue for the web?

CatHood0 commented 2 months ago

@CatHood0 Is this a reason for this check or maybe it's for preventing an issue for the web?

Was this why it didn't work? I understand it now. Believe me, I completely forgot that I added that condition which, now that I see it, did nothing. Thanks for that quick fix. I already thought it would be something else.

And to answer you, no, I really doubt it did anything, and I don't think I remember why I added it.

stvhrs commented 2 months ago

thanks bro