Closed CatHood0 closed 2 months ago
EchoEllet
commented
2 months ago Can you mark it as experimental with the annotation and deprecated as well? I'm not saying we should remove it anytime soon but since we don't recommend users use it in production applications, we should be able to give users more time when we can.
Update: Can you mark it as experimental to make it more clear why it's deprecated?
CatHood0
commented
2 months ago Can you mark it as experimental with the annotation and deprecated as well? We do want to give users more time. I'm not saying we should remove it anytime soon but since we don't recommend users use it in production applications, we should
That's exactly what I just did
CatHood0
commented
2 months ago Update: Can you mark it as experimental to make it more clear why it's deprecated?
I already do it. Can you check if i missing something?
EchoEllet
commented
2 months ago I already do it. Can you check if i missing something?
LGTM.
EchoEllet
commented
2 months ago The support for tables is currently limited and underdevelopment, more changes are expected to arrive. We are actively working on enhancing its functionality and usability. We appreciate your feedback as it is invaluable in helping us refine and expand this feature.
This part in README.md of flutter_quill_extensions is outdated. We need to remove it or indicate that it's no longer a supported feature.
CatHood0
commented
2 months ago This part in README.md of flutter_quill_extensions is outdated. We need to remove it or indicate that it's no longer a supported feature.
I'll take a look as soon as possible.
EchoEllet
commented
2 months ago Updated.
CatHood0
commented
2 months ago Updated.
Thanks for taking the efforts and the time.
Description
It was decided to disable embed tables for the moment.
Why was this decision made? It's not hard to see. Not only are there notable visual errors, but also in the logic itself of adding columns, rows, and even where the popup that allows us to add new tables to the document should appear.
This feature was implemented at a very early stage and should not have been allowed to be implemented as if it were a totally stable feature without bugs (or at least not many). The best thing for the moment, instead of removing it, is to disable it so that the end user does NOT have access to it and allows us to improve it to a point where we can verify that it is stable and can be implemented along with the other features.
A PR will be coming soon to try to improve this implementation. However, there are priorities and we have to solve the problems that most affect the editor (such as the problem with the indent attribute and even the performance, which is quite bad on web and mobile).
Related Issues
Related #2193
Related #2130
[ ] ✨ New feature: Adds new functionality without breaking existing features.
[x] 🛠️ Bug fix: Resolves an issue without altering current behavior.
[ ] 🧹 Code refactor: Code restructuring that does not affect behavior.
[ ] ❌ Breaking change: Alters existing functionality and requires updates.
[ ] 🧪 Tests: Adds new tests or modifies existing tests.
[ ] 📝 Documentation: Updates or additions to documentation.
[x] 🗑️ Chore: Routine tasks, or maintenance.
[ ] ✅ Build configuration change: Changes to build or deploy processes.