search

singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.54k stars 816 forks source link

No named parameter with the name 'onPopInvokedWithResult' , if still using flutter 3.22 . #2289

Open toknT opened 2 days ago

toknT commented 2 days ago

Is there an existing issue for this?

Flutter Quill version

9.6.0

Steps to reproduce

1 . install flutter 3.22 2 . create a new project

  1. install and use flutter_quill flutter_quill_extensions as example 3 . build ios

Expected results

build success

Actual results

Error (Xcode): ../../../../.pub-cache/hosted/pub.dev/youtube_player_flutter-9.0.4/lib/src/widgets/youtube_player_builder.dart:78:9: Error: No named parameter with the name 'onPopInvokedWithResult'.

Additional Context

this issue is caused by youtube_player_flutter . https://github.com/sarbagyastha/youtube_player_flutter/issues/978 . However I am not using video in editor.

EchoEllet commented 2 days ago

We have removed youtube_player_flutter and flutter_inappwebview from flutter_quill_extensions in 10.8.0. Related PR #2286. Discussed in #2284.

It seems that they might have changed something without increasing the minimum Flutter SDK. Both youtube_player_flutter and flutter_inappwebview have introduced some changes that can be considered as breaking changes in a minor version, pub attempt to use the latest compatible version, when the newer version is not compatible with the minimum Flutter SDK defined, support for Windows and macOS require additional steps, when it was introduced and pub used the latest version, more steps are required to build the project which doesn't inform the users.

Should be fixed in the latest version. Can you confirm if this is an issue with 10.8.0?