singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.6k stars 839 forks source link

Inconsistency in parameters between QuillController, QuillControllerConfigurations, QuillEditor, QuillEditorConfigurations #2298

Open EchoEllet opened 1 month ago

EchoEllet commented 1 month ago

I tried updating an old app (for testing purposes) that uses flutter_quill, and while updating from version 9.0.0 to 9.5.10 and then to 10.0.0 I can see why the question in #2094 is asked.

We're developing the project without getting any feedback from users.

There are inconsistency issues and breaking change issues made in minor versions, see comment in #2097 for more details.

For this issue, those two PRs #1843 and #1843 have changes that are inconsistent with each other since we didn't take much time to review those PRs

https://github.com/singerdmx/flutter-quill/blob/master/lib/src/controller/quill_controller.dart#L26-L39

https://github.com/singerdmx/flutter-quill/blob/master/lib/src/controller/quill_controller_configurations.dart#L4-L25

https://github.com/singerdmx/flutter-quill/blob/master/lib/src/editor/editor.dart#L184-L192

https://github.com/singerdmx/flutter-quill/blob/master/lib/src/editor/config/editor_configurations.dart#L42

I haven't taken the time to discover all potential issues though noticed: