singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.6k stars 839 forks source link

Localization issue with Image picker menu popup #2335

Closed AlexBeehave closed 1 week ago

AlexBeehave commented 4 weeks ago

Is there an existing issue for this?

Flutter Quill version

10.8.4

Steps to reproduce

  1. Create a Flutter toolbar editor with a French Locale: QuillToolbar.simple( controller: _controller, configurations: QuillSimpleToolbarConfigurations( showCodeBlock: false, showSearchButton: false, showFontFamily: false, embedButtons: FlutterQuillEmbeds.toolbarButtons(), sharedConfigurations: QuillSharedConfigurations( locale: const Locale('fr'), ), ), )
  2. Start your quill editor with toolbar

Expected results

The image and video caption button should be both in French. The imagePicker menu should be in French.

Actual results

Only the image button caption is in French. The imagePicker menu is in English. Screenshot_20241025_220952 Screenshot_20241025_220907 Screenshot_20241025_220819

Additional Context

Debug analysis The context when the class SelectImageSourceDialog is build is in English. There seems to be a disruption between the context given in the toolbar button and the context given to the popup. builder: (_) => const FlutterQuillLocalizationsWidget( child: SelectImageSourceDialog(), ), Not sure exactly why...
EchoEllet commented 3 weeks ago

The issue with the SelectImageSourceDialog has been fixed in #2338.

image

As for the insert video tooltip, there is a TODO to localize it.