search

singerdmx / flutter-quill

Rich text editor for Flutter
https://pub.dev/packages/flutter_quill
MIT License
2.6k stars 839 forks source link

The example/pubspec.lock file should be included #2341

Closed EchoEllet closed 2 weeks ago

EchoEllet commented 3 weeks ago

The file pubspec.lock is essential to check in the example to ensure that we test within the same dependencies versions, otherwise running flutter pub upgrade will upgrade the dependencies to use their latest compatible version and doesn't change the checked pubspec.yaml which have the minimum versions.

For the library packages it should not be checked, for app packages, it's important to check them, see related dart docs.

What we should do first is extract the flutter_quill package files into its directory flutter_quill and not the root of the project, this will also ensure the package doesn't conflict with the docs directory (had to rename it to doc which is for dart generated doc) since it's dart convention but it's separated. Will ensure unrelated files (e.g., flutter_quill_extensions, scripts) will not be uploaded to each version of flutter_quill. Can solve some other minor issues.

EchoEllet commented 2 weeks ago

Fixed in the release/v11 branch.