Abhishek feature branch

abhishekshivgan commented 3 weeks ago

Bugs:

Footer content was not visible because of the Plus Icon. #69
Just to view the Blogs, user has to login. This is not ideal for any user. It highly increases the bounce rate of the site.

Type of change

I have aligned all the elements in center so that it is visible and looks beautiful. Now the footer is completely visible
I have shifted blog routes from protected route to public route. This way, if a user visits a blog, he will be able to read the blog. This will decrease the bounce rate. The inspiration for this feature is Medium Blogging Site.

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

myblog

netlify[bot] commented 3 weeks ago

Deploy Preview for tech-stuffs ready!

Name	Link
Latest commit	62263a8862bb01f67a4bc1c89d6391e6088619ca
Latest deploy log	https://app.netlify.com/sites/tech-stuffs/deploys/66d6eeb2a933930008406748
Deploy Preview	https://deploy-preview-171--tech-stuffs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 weeks ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

singhJasvinder101 commented 3 weeks ago

Great work @abhishekshivgan but speeddial is still hiding the footer content https://deploy-preview-171--tech-stuffs.netlify.app/

also you can fix the white space above the footer issue for lower screens

abhishekshivgan commented 3 weeks ago

Great work @abhishekshivgan but speeddial is still hiding the footer content https://deploy-preview-171--tech-stuffs.netlify.app/

also you can fix the white space above the footer issue for lower screens

Can you provide some more insights on this speeddial component. I am not getting what you are referring to. A screenshot would be nice.

I will also look at the white space in footer

singhJasvinder101 commented 3 weeks ago

For lower screens

abhishekshivgan commented 3 weeks ago

@singhJasvinder101 got it. where exactly do you prefer to align the speeddial component?

singhJasvinder101 commented 3 weeks ago

little bottom margin will be fine I think. Main thing is It must not hide footer content for lower screens

singhJasvinder101 commented 2 weeks ago

are you working on this issue ?

singhJasvinder101 / MyBlog