search

singingwolfboy / flask-dance

Doing the OAuth dance with style using Flask, requests, and oauthlib.
https://pypi.python.org/pypi/Flask-Dance/
MIT License
1.01k stars 158 forks source link

fix tests and adjust dependencies #381

Closed singingwolfboy closed 2 years ago

singingwolfboy commented 2 years ago

Flask 2.1.0 has the following changelog entry:

From Werkzeug, for redirect responses the Location header URL will remain relative, and exclude the scheme and domain, by default.

This fixes the tests to account for that. In the process of doing so, I discovered that older versions of Flask no longer install and run correctly, due to unconstrained dependency definitions. As a result, this project will no longer support those versions of Flask.

codecov[bot] commented 2 years ago

Codecov Report

Merging #381 (68b5018) into main (e50939d) will decrease coverage by 0.92%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
- Coverage   93.87%   92.94%   -0.93%     
==========================================
  Files          35       35              
  Lines        1077     1077              
==========================================
- Hits         1011     1001      -10     
- Misses         66       76      +10
Impacted Files Coverage Δ
flask_dance/consumer/base.py 84.26% <0.00%> (-6.75%) :arrow_down:
flask_dance/consumer/oauth1.py 67.41% <0.00%> (-2.25%) :arrow_down:
flask_dance/consumer/oauth2.py 90.56% <0.00%> (-1.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e50939d...68b5018. Read the comment docs.