singingwolfboy / flask-dance

Doing the OAuth dance with style using Flask, requests, and oauthlib.
https://pypi.python.org/pypi/Flask-Dance/
MIT License
1.01k stars 158 forks source link

add @daenney as official maintainer #405

Closed singingwolfboy closed 2 years ago

singingwolfboy commented 2 years ago

Hey @daenney, I should have done this awhile ago, but better late than never, I suppose! Would you like to be in the pyproject.toml file as a maintainer for the project? And if so, which email would you like to use? (It will be public!)

codecov[bot] commented 2 years ago

Codecov Report

Merging #405 (5d25f79) into main (8df2253) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 5d25f79 differs from pull request most recent head e95e31c. Consider uploading reports for the commit e95e31c to get more accurate results

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          36       36           
  Lines        1048     1048           
=======================================
  Hits          979      979           
  Misses         69       69           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

daenney commented 2 years ago

Thanks for doing this! There's no way to not have the email in there is there? I prefer to not list that publicly because it tends to result in a lot of spam etc. and I'd rather folks jump on the issue tracker here than shoot me an email.

singingwolfboy commented 2 years ago

Nope, looks like both name and email are optional keys here! I've taken out the email key, so it's just your name. Is that what you want?

daenney commented 2 years ago

Yap, that'll do! Thanks