singingwolfboy / flask-dance

Doing the OAuth dance with style using Flask, requests, and oauthlib.
https://pypi.python.org/pypi/Flask-Dance/
MIT License
1.01k stars 158 forks source link

Enable token refresh for Gitlab #422

Open ryan-s opened 1 year ago

ryan-s commented 1 year ago

Gitlab removed support for optionally expiring tokens in Gitlab 15.0. Adding in the refresh as optional since there may be self hosted instances in the wild older then 15.0.

https://docs.gitlab.com/ee/integration/oauth_provider.html#access-token-expiration

codecov[bot] commented 1 year ago

Codecov Report

Merging #422 (a8d5bac) into main (27add75) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   96.35%   96.36%   +0.01%     
==========================================
  Files          37       37              
  Lines        1070     1073       +3     
==========================================
+ Hits         1031     1034       +3     
  Misses         39       39              
Files Changed Coverage Δ
flask_dance/contrib/gitlab.py 96.00% <100.00%> (+0.54%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ryan-s commented 1 year ago

Pinned pillow to 9.5 based on https://bugs.launchpad.net/tacker/+bug/2026345

daenney commented 1 year ago

Pinned pillow to 9.5 based on https://bugs.launchpad.net/tacker/+bug/2026345

Ah, nice catch. Thank you!