search

singingwolfboy / flask-dance

Doing the OAuth dance with style using Flask, requests, and oauthlib.
https://pypi.python.org/pypi/Flask-Dance/
MIT License
997 stars 156 forks source link

Enable token refresh for azure #428

Closed emilhe closed 5 months ago

emilhe commented 5 months ago

This PR adds the capability of automatic token refresh to the azure bindings.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92189b1) 96.63% compared to head (30e3bf1) 96.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #428 +/- ## ======================================= Coverage 96.63% 96.64% ======================================= Files 37 37 Lines 1070 1072 +2 ======================================= + Hits 1034 1036 +2 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

daenney commented 5 months ago

Hiya, thanks for the change! It looks good, but the test file no longer passes the formatting check. All you should have to do is run black and it'll correct it. After that I think we can merge it.

singingwolfboy commented 5 months ago

Could you add something to the docstring of that function, mentioning the automatic token refresh and how to activate it? If you can include a link to the Azure documentation about this topic, that would be even better!

Remember that Sphinx uses this docstring to build the documentation for this project, so people who want to use Flask-Dance will see this, even if they never look at the code!

emilhe commented 5 months ago

@singingwolfboy That's a good idea. I have added a docstring and a link.

singingwolfboy commented 5 months ago

This looks great to me! Thanks @emilhe!