fix Discord prompt parameter

singingwolfboy / flask-dance

Doing the OAuth dance with style using Flask, requests, and oauthlib.

https://pypi.python.org/pypi/Flask-Dance/

MIT License

997 stars 156 forks source link

fix Discord prompt parameter #433

Closed owencompher closed 3 months ago

owencompher commented 3 months ago

the Discord authentication url expects the prompt argument to be "consent" or "none", by default "consent". If set as None in the blueprint constructor, it remains None until it is passed to the url, where it is left off entirely. Changing it to "none" fixes the issue without the possibility of breaking any other providers.

It looks like this is the only provider with this kind of issue.

singingwolfboy commented 3 months ago

Great! Could you please add a test to cover these cases? (Both "none" and "consent" should be tested.)

owencompher commented 3 months ago

I would consider tweaking the docs to remove the ambiguity between the string "None" and the builtin None. I'm not sure about the best way to do that so I'll leave it up to you

singingwolfboy commented 3 months ago

Thanks so much!