search

single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
69 stars 9 forks source link

[python] Mutable-X mods, and explicit shaping of `SparseNDArray` #131

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

Implements the spec side of the plan laid out in issue https://github.com/single-cell-data/TileDB-SOMA/issues/931.

This PR addresses only explicit shaping of SparseNDArray -- explicit shaping of DataFrame will be on a separate PR.

johnkerl commented 1 year ago

@bkmartinjr given https://github.com/single-cell-data/SOMA/pull/131 and latest commit on this PR https://github.com/single-cell-data/SOMA/pull/131/commits/2fa64b9b260ebec3c5a4ce8cb53d0519817029d8 can you take another look please?

bkmartinjr commented 1 year ago

can you take another look please

I have not had a chance to take any look - sorry, lots of threads.

Given the confusion on the design change, I would prefer we let that settle out, then review this PR.

johnkerl commented 1 year ago

@bkmartinjr when you click through the links I wrote you'll see that restoration of COO is a go

Pending changes on https://github.com/single-cell-data/TileDB-SOMA/pull/952 include:

-- none of which affect the spec

I had hoped to merge this PR but, sure, take all the time you need.

Afternote: indeed there is one more mod, good call. :)