search

single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
69 stars 9 forks source link

[python] Explicit shaping for `DataFrame` #143

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

Context: https://github.com/single-cell-data/TileDB-SOMA/issues/961

This is a prerequisite for https://github.com/single-cell-data/TileDB-SOMA/pull/1027.

Note that for SparseNDArray it sufficed to have a slotwise int shape: indexing is only by int64 and we took the min to be 0, leaving only the max to be specified. Here, for DataFrame, indices can be of various types so we truly must do parameterizations in terms of domains -- min-max pairs on each dim slot.

bkmartinjr commented 1 year ago

if Brian is happy with it I am

I don't think Brian is on the review - add him?

(joking - I assume this was a typo)