search

single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
69 stars 9 forks source link

Allow impl-specific `platform_config` values #165

Closed thetorpedodog closed 1 year ago

thetorpedodog commented 1 year ago

This specifies that implementations may provide their own types to be passed as platform_config, and that other implementations should ignore things they don’t recognize.

Per the discussion at Friday’s meeting about allowing users to pass in rich objects, this is roughly what I was thinking would be the best approach. It’s pretty much what I said there, and tl;dr

  1. Implementations can choose to accept their own rich types raw.
  2. Other implementations should ignore ones they don't recognize and act as if nothing was passed.

I only vaguely remember who was most involved in that discussion, so please R+ anybody who seems relevant.

Tracking: https://github.com/single-cell-data/TileDB-SOMA/issues/1394

thetorpedodog commented 1 year ago

@pablo-gar bump, since this a spec change I would like all reviewers' approval. (If I misremembered the conversation and you didn’t have an opinion on this, you can remove yourself from the reviewers list (or approve if you think this is a good idea anyway).)