search

single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
72 stars 9 forks source link

ExperimentAxisQuery uses the thread pool from ContextBase #184

Closed ebezzi closed 7 months ago

ebezzi commented 8 months ago

Companion PR to: https://github.com/single-cell-data/TileDB-SOMA/pull/2001

thetorpedodog commented 8 months ago

If we're going to do this, we should also change the places where it is accepted in parameters / returned from accessors to be this base context protocol.

I also feel like the threadpool member should be public (i.e., un-prefixed), since it is intended for semi-public consumption (within SOMA libraries, but still).

ebezzi commented 8 months ago

If we're going to do this, we should also change the places where it is accepted in parameters / returned from accessors to be this base context protocol.

I also feel like the threadpool member should be public (i.e., un-prefixed), since it is intended for semi-public consumption (within SOMA libraries, but still).

Good points. I implemented both. Let me know if you know other usages I missed, and if you want a different naming/location for ContextBase.