single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
70 stars 9 forks source link

Add missing exported classes to somacore #79

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

We need to export Measurement and Experiment in addition to Collection. While it is true the first two are specializations of the third, they are not all interchangeable. Specifically, we use soma_type: Final = "SOMAMeasurement" and soma_type: Final = "SOMAExperiment" as inherited in their analogous TileDB-SOMA classes. If TileDB-SOMA's Measurement inherits from somacore.Collection then its soma_type will be wrong; which is of course unacceptable.

Context: https://github.com/single-cell-data/TileDB-SOMA/issues/669

johnkerl commented 1 year ago

No longer needed on https://github.com/single-cell-data/TileDB-SOMA/pull/678

With @thetorpedodog 's able help we were able to get https://github.com/single-cell-data/TileDB-SOMA/pull/678 working with 0.0.0a2 of somacore.