search

single-cell-data / SOMA

A flexible and extensible API for annotated 2D matrix data stored in multiple underlying formats.
MIT License
70 stars 9 forks source link

Switch from `ndims` to `ndim` #84

Closed johnkerl closed 1 year ago

johnkerl commented 1 year ago

From https://github.com/single-cell-data/TileDB-SOMA/issues/744, as it turns out this is spec-only.

Context there: NumPy, SciPy, Pandas, et al. use ndim -- so should we. Affects spec, Python impl, and R impl.

This wasn't caught sooner since, unlike other properties in NDArray, ndims does not have the @abc.abstractmethod:

https://github.com/single-cell-data/SOMA/blob/python-v0.0.0a3/python-spec/src/somacore/data.py#L84-L99