Closed nguyenv closed 2 months ago
Attention: Patch coverage is 95.91837%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 89.89%. Comparing base (
eab6557
) to head (1ade53f
).
The changes in this PR are now encompassed by:
Issue and/or context:
https://github.com/single-cell-data/TileDB-SOMA/issues/2674
These changes are applied on top of https://github.com/single-cell-data/TileDB-SOMA/pull/2508
Changes:
tiledb.Group
usage withclib.SOMAGroup
tiledb.TileDBError
as we no longer have exceptions coming from tiledb-pyArrayWrapper
andGroupWrapper
as these were wrappers around tiledb-py objectsCollectionWrapper
,ExperimentWrapper
, andMeasurementWrapper
to wrap around new C++ bindingsTileDBObject
toSOMAObject
and_tiledb_object.py
to_soma_object.py
to reflect moveover changesNotes for Reviewer:
Although
SOMAArray
andSOMAGroup
now fully use the C++ bindings, there's still areas of the code that use tiledb-py and need to be replaced in a follow up PR. For example, we usetiledb.VFS
in several areas.