Closed eddelbuettel closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.16%. Comparing base (
6d6c90e
) to head (f115d43
). Report is 2 commits behind head on main.
@nguyenv Thanks for the review! We could also split this off if your PR #2629 went in by itself I could rebase. I have no preference which way we do this but I do have a preference for this getting done sooner rather than later, if possible, as subsequent work of mine depends on both.
I am totally fine with leaving this is a single large PR. I think that would be easiest and fastest tbh. I just wanted to leave some context for my own changes for anyone else who is reviewing this.
@mojaveazure Give it anoother look, please -- your comment was spot and I addressed it in follow-up commit https://github.com/single-cell-data/TileDB-SOMA/pull/2704/commits/f115d43c770f19b449e1ca23f245f0673dae58c7.
Thanks for adding in the error-on-exists! From an R standpoint, this looks good to me! I'll defer to others for Python and C++
Thanks for catching that. Much better with the explicit (earlier than in core) error.
The backport to release-1.12
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.12 release-1.12
# Navigate to the new working tree
cd .worktrees/backport-release-1.12
# Create a new branch
git switch --create backport-2704-to-release-1.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 cca332611545ec734acf149436954b04ad095f37
# Push it to GitHub
git push --set-upstream origin backport-2704-to-release-1.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.12
Then, create a pull request where the base
branch is release-1.12
and the compare
/head
branch is backport-2704-to-release-1.12
.
Backport unneeded: error on my part: this was merged to main
just before release-1.12
was branched off of main
Issue and/or context:
This PR switches data frame write operations to using
libtiledbsoma
. It contains the branchviviannguyen/fix ordered dictionary flag
as well.Changes:
Enable schema creation and data.frame writes.
Notes for Reviewer:
~This PR is (for now) still flagged WIP and 'draft' as a pass or two for cleanup may be needed removing some comments and alike.~ However, as it passes all tests locally it is ready for CI.
The commit history is missing timestamps because of rebasing. The initial branch started a while ago, and Vivian's branch was merged another while back too. My predecessor branch is (for now) still up as is Vivian's branch merged here.
SC 44885