single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
MIT License
81 stars 21 forks source link

Small updates to match somacore #2712

Closed jp-dark closed 1 month ago

jp-dark commented 1 month ago

Update TileDB-SOMA to match the following spatial somacore changes:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (feb67b8) to head (56fc67f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## spatial #2712 +/- ## =========================================== - Coverage 87.17% 87.11% -0.07% =========================================== Files 41 41 Lines 4296 4299 +3 =========================================== Hits 3745 3745 - Misses 551 554 +3 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2712/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `87.11% <0.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2712/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2712/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `87.11% <0.00%> (-0.07%)` | :arrow_down: | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2712/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |
github-actions[bot] commented 1 month ago

The backport to release-1.12 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.12 release-1.12
# Navigate to the new working tree
cd .worktrees/backport-release-1.12
# Create a new branch
git switch --create backport-2712-to-release-1.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 50697146f0acd13fddb22bf3f5a5650fb236a727
# Push it to GitHub
git push --set-upstream origin backport-2712-to-release-1.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.12

Then, create a pull request where the base branch is release-1.12 and the compare/head branch is backport-2712-to-release-1.12.

johnkerl commented 1 month ago

I should not have even attempted a backport -- this was a PR to spatial not to main ...