single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
MIT License
81 stars 21 forks source link

[c++] Fix a nightly-build issue #2718

Closed johnkerl closed 1 month ago

johnkerl commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (5ad2225) to head (e9e0739).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2718 +/- ## ======================================= Coverage 90.17% 90.17% ======================================= Files 37 37 Lines 4022 4022 ======================================= Hits 3627 3627 Misses 395 395 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2718/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `90.17% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2718/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2718/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `90.17% <ø> (ø)` | | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2718/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |
johnkerl commented 1 month ago

Evaluating post-merge as per @jdblischak instructions here: https://github.com/TileDB-Inc/tiledbsoma-feedstock/issues/170#issuecomment-2163344686

Manual run: https://github.com/TileDB-Inc/tiledbsoma-feedstock/actions/runs/9485993041

johnkerl commented 1 month ago

@jdblischak I'm confused -- the entirety of https://github.com/TileDB-Inc/tiledbsoma-feedstock/actions/runs/9485993041/job/26139272758 completed (☘️ , which seems good) in one minute fifty-three seconds which I can't believe included a full recompile and unit-test run ... 👀

jdblischak commented 1 month ago

which I can't believe included a full recompile and unit-test run

xref: https://github.com/TileDB-Inc/tiledbsoma-feedstock/issues/170#issuecomment-2163510654