search

single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
https://tiledbsoma.readthedocs.io
MIT License
87 stars 25 forks source link

[c++] Add additional layout string representations #2721

Open nguyenv opened 3 months ago

nguyenv commented 3 months ago

These additional string representations are used in R for the PlatformConfig and align with what is used in core.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (abdfda2) to head (de414e7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2721 +/- ## ======================================= Coverage 90.17% 90.17% ======================================= Files 37 37 Lines 4022 4022 ======================================= Hits 3627 3627 Misses 395 395 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2721/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2721/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `90.17% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2721/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2721/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `90.17% <ø> (ø)` | | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2721/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |
eddelbuettel commented 3 months ago

Not sure why the test now barks after you made it more not less general. Hm.

nguyenv commented 3 months ago

https://github.com/single-cell-data/TileDB-SOMA/pull/2721/files#diff-c66edd736f9a9cb059c6f6e0f4cc6d1cdfa0fd91a2b9220dd2e83c12c2546089R451-R454

We do cast to lowercase here.

eddelbuettel commented 3 months ago

Try flipping this on line 418 of apis/r/tests/testthat/test-SOMADataFrame.R

  expect_equal(tiledb::capacity(tsch), 8000)
  expect_equal(tiledb::tile_order(tsch), "ROW_MAJOR")     # comment out or change to COL_MAJOR
  expect_equal(tiledb::cell_order(tsch), "ROW_MAJOR")