search

single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
MIT License
79 stars 21 forks source link

[r,c++] Support dense nd array write case #2730

Closed eddelbuettel closed 2 weeks ago

eddelbuettel commented 3 weeks ago

Issue and/or context:

This PR extends the C++-fication to dense n-dimensional array.

Changes:

Refactored code to use C++ classes to write.

Notes for Reviewer:

SC 44887

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.32%. Comparing base (c33f934) to head (dce48fb). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2730 +/- ## ========================================== - Coverage 89.91% 89.32% -0.60% ========================================== Files 37 37 Lines 4026 4037 +11 ========================================== - Hits 3620 3606 -14 - Misses 406 431 +25 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2730/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2730/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `89.32% <ø> (-0.60%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2730/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2730/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `89.32% <ø> (-0.60%)` | :arrow_down: | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2730/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |
eddelbuettel commented 3 weeks ago

Marked as draft as some of the sparse cases blow up.

eddelbuettel commented 3 weeks ago

I have now spent days debugging this, and it tends to pass on why machine but continues to bonk on Linux at CI.

eddelbuettel commented 2 weeks ago

And then just re-running it makes it green :man_shrugging:

@nguyenv @mojaveazure please review at your convenience