Closed nguyenv closed 4 days ago
My idea for the latter conerns: When creating a SOMAArray
in C++, we can store the PlatformConfig
that's passed in to generate the ArraySchema
. Then have a platform_config
getter that we can bind in the APIs. In Python, we could return that as a JSON formatted string.
So essentially your first bullet point.
I think we should install tiledb-py when running CI. We could have a requirements_ci.txt
that pulls everything from requirements_dev.txt
with just the additional requirement for tiledb
. But yes we'd have to make sure the version of tiledb-py it pulls is compatible with the libtiledbsoma in tiledbsoma-py. I don't know how to deal with that yet but can look into it.
My idea for the latter conerns: When creating a SOMAArray in C++, we can store the PlatformConfig that's passed in to generate the ArraySchema. Then have a platform_config getter that we can bind in the APIs. In Python, we could return that as a JSON formatted string.
So essentially your first bullet point.
Hmm, I hadn't thought of that. TBH I don't think this is a good check -- it will be checking a copy of platform config stored somewhere, not checking against readback of the actual core schema that was created. We need to actually read the core schema and do these checks -- if we want to continue doing them at all ...
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.28%. Comparing base (
176bbf8
) to head (09aa14b
). Report is 5 commits behind head on main.
All changes in this branch have been split out into multiple PRs and merged into main.
Issue and/or context:
This PR is separated out from https://github.com/single-cell-data/TileDB-SOMA/pull/2752
Changes:
config_options_from_schema
binding to retrieveArraySchema
info not encapsulated by theArrowSchema
dims
andattrs
by returningtile
fordims
and usingfilters
keys forFilterList
valuestiledb.FilterList
withPlatformConfig
's JSON formatted stringsis_relative
forSOMAGroup
sVFS
orFragmentInfoList
) now uselibpath.Path
'siterdir