search

single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
https://tiledbsoma.readthedocs.io
MIT License
90 stars 25 forks source link

[c++] Add `dataset_type` into `SOMAExperiment` metadata #2884

Closed nguyenv closed 2 months ago

nguyenv commented 2 months ago

Tracking: #2885

As caught interally, the dataset_type needs to be set to soma for SOMAExperiment on tiledb-cloud upon creation.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.69%. Comparing base (46fdeee) to head (b02ef2d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2884 +/- ## ======================================= Coverage 89.69% 89.69% ======================================= Files 37 37 Lines 3940 3940 ======================================= Hits 3534 3534 Misses 406 406 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2884/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2884/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `89.69% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2884/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2884/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `89.69% <ø> (ø)` | | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2884/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |
nguyenv commented 2 months ago

LGTM other than John's comment about doing it regardless of URI. Do we want to also remove the _set_create_metadata methods from Experiment and SOMAObject during this or a follow-on PR?

Good point. I will remove those in a follow-up PR.

johnkerl commented 2 months ago

Good point. I will remove those in a follow-up PR.

@nguyenv's going on well-deserved PTO so I've put up #2887