Closed johnkerl closed 2 months ago
Issue and/or context: For #2698
I ran an audit here: https://gist.github.com/johnkerl/a9eb64de62f881e80cd8e7ee54aa1c5c
Findings:
TILEDB_STRING_UTF8
np.array
As a result:
Confounding circumstances:
"foo"
b"foo"
Changes:
Write post-create metadata updates from Python correctly using UTF-8 types.
Notes for Reviewer:
After this PR is merged I'll do cross-language tests in apis/system/tests to automate the kinds of things shown at gist https://gist.github.com/johnkerl/a9eb64de62f881e80cd8e7ee54aa1c5c
apis/system/tests
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.03%. Comparing base (ab0a5b5) to head (69c79d5). Report is 2 commits behind head on main.
ab0a5b5
69c79d5
Issue and/or context: For #2698
I ran an audit here: https://gist.github.com/johnkerl/a9eb64de62f881e80cd8e7ee54aa1c5c
Findings:
TILEDB_STRING_UTF8
np.array
at https://github.com/single-cell-data/TileDB-SOMA/blob/1.13.0/apis/python/src/tiledbsoma/_tdb_handles.py#L531-L536 and I was unable to find a dtype that did the right thingTILEDB_STRING_UTF8
As a result:
Confounding circumstances:
"foo"
b"foo"
...Changes:
Write post-create metadata updates from Python correctly using UTF-8 types.
Notes for Reviewer:
After this PR is merged I'll do cross-language tests in
apis/system/tests
to automate the kinds of things shown at gist https://gist.github.com/johnkerl/a9eb64de62f881e80cd8e7ee54aa1c5c