single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
https://tiledbsoma.readthedocs.io
MIT License
90 stars 25 forks source link

[r] Small robustification for version comparison #2914

Closed eddelbuettel closed 2 months ago

eddelbuettel commented 2 months ago

Issue and/or context:

When comparing major.minor versions of the underlying library we were reconstruction <major,minor,patch> from the string when we do actually have the components and can use then directly.

Changes:

This applies a small simplification to supply a two element <major,minor> vector as needed for the comparison and also uses the vector form the other version. This allow us to remove two strsplit() calls.

Notes for Reviewer:

SC 50630

I put this together after the previous vacation and didn't PR it yet as it wasn't that important but seeing that we are doing other cleanups this weekend may as well put it up.