Closed johnkerl closed 1 month ago
Rebased onto fresh main
just now (as planned)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.02%. Comparing base (
08193f2
) to head (fd9d7cf
). Report is 2 commits behind head on main.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
This is not strictly necessary -- all is does is remove some code duplication, which is a cosmetic nice-to-have. However, I found it helpful fo help me understand the functions in
libtiledbsoma/test/common.cc
, since I'll need to add to it.Specifcally:
SparseNDArray
andDenseNDArray
are always indexed byint64
SOMADataFrame
is indexed by default with a singleint64
soma_joinid
int64
soma_joinid
-- or, they can have one or more dims whilesoma_joinid
is merely an attr, not a dim at all.That third bullet has been unit-tested in TileDB-SOMA-Py for some time now; it hasn't been unit-tested in
libtiledbsoma
at all. For the changes on #2407 I'd like to rectify that, to increase confidence in PRs such as #2917.Notes for Reviewer:
Currently this is stacked atop
kerl/cpp-resizes
which is PR #2917. If this PR can be approved sooner than some of the other ones on #2407 (and I believe it should be) then I will rebase this on top of currentmain
in an attempt to unstack it from #2917.