Closed eddelbuettel closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.88%. Comparing base (
331a1b6
) to head (af225dc
). Report is 2 commits behind head on main.
I put one microfix in following review but as discussed in parallel it maybe beneficial to attach this in parallel.
Thanks for #2929 and the follow-up comments here.
Issue and/or context:
This PR adds the ability to write, and read, at given time stamps covering the key SOMA object data frame as well as sparse and dense arrays.
There is a corresponding follow-up PR #2925 which exposes time points (as before) as well as range (begin and end) as taken by the C++ API.
Changes:
Code changes as well as a new test file. It also contains two additional smaller PRs (#2866, #2871).
Notes for Reviewer:
SC 52516
The branch had been open for two-plus weeks and has been rebased a few times so the final commit timestamps are not from the initial commits.