single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.
https://tiledbsoma.readthedocs.io
MIT License
90 stars 25 forks source link

Move CoordinateSpace and CoordinateTransform to SOMA #2943

Closed jp-dark closed 1 month ago

jp-dark commented 1 month ago

This removes the Axis, CoordinateSpace, and CoordinateTransform classes from TileDB-SOMA and instead imports them from somacore. It also replaces the return type of AffineTransform with ScaleTransform when getting transformations of the levels of the Image2DCollection (soon to be MultiscaleImage).

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (eb71e83) to head (ee8438c). Report is 1 commits behind head on spatial.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## spatial #2943 +/- ## =========================================== + Coverage 79.90% 80.18% +0.28% =========================================== Files 45 45 Lines 4867 4719 -148 =========================================== - Hits 3889 3784 -105 + Misses 978 935 -43 ``` | [Flag](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2943/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2943/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `80.18% <59.37%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2943/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | Coverage Δ | | |---|---|---| | [python_api](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2943/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `80.18% <59.37%> (+0.28%)` | :arrow_up: | | [libtiledbsoma](https://app.codecov.io/gh/single-cell-data/TileDB-SOMA/pull/2943/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=single-cell-data) | `∅ <ø> (∅)` | |