Closed johnkerl closed 1 month ago
Attention: Patch coverage is 70.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 89.99%. Comparing base (
796c168
) to head (7a397c4
). Report is 1 commits behind head on main.
Thanks for the well written documentation
You're welcome! The core-to-soma mapping is absoutely the central part of this project, and the names can get very confusing -- so I believed it was well worth the time to clarify terminology. :)
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
domain
andmaxdomain
to PythonNotes for Reviewer:
There is no R counterpart on this PR (compare #2951 which is at parity):
domain
accessor for arrays, and so nothing to put amaxdomain
next to$dimensions()
accessordomain
argument toSOMADataFrame
'screate
as TileDB-SOMA-Py does -- I'll file a tracking issue