[r] `SOMADataFrame` `create` needs to accept a `domain` argument - Githubissues

single-cell-data / TileDB-SOMA

Python and R SOMA APIs using TileDB’s cloud-native format. Ideal for single-cell data at any scale.

https://tiledbsoma.readthedocs.io

MIT License

90 stars 25 forks source link

[r] `SOMADataFrame` `create` needs to accept a `domain` argument #2967

Closed johnkerl closed 2 weeks ago

johnkerl commented 1 month ago

Found while working on issue #2407 / [sc-51048]. See also [sc-55657].

Python

The SOMADataFrame create method accepts domain here:

R

The SOMADataFrame create method does not accept domain here:

https://github.com/single-cell-data/TileDB-SOMA/blob/248f46e50096eee3c707eb29dd3d0e7a32e6a466/apis/r/R/SOMADataFrame.R#L26-L31

For this reason, here https://github.com/single-cell-data/TileDB-SOMA/blob/248f46e50096eee3c707eb29dd3d0e7a32e6a466/apis/r/R/SOMADataFrame.R#L49-L53 calling here https://github.com/single-cell-data/TileDB-SOMA/blob/248f46e50096eee3c707eb29dd3d0e7a32e6a466/apis/r/R/utils-arrow.R#L363 the domain is taken from the datatype's max range.

This is a R/Python parity issue which will become noticeable on #2407 and should be prioritized.