Closed johnkerl closed 1 month ago
Attention: Patch coverage is 96.49123%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 61.15%. Comparing base (
0efe51a
) to head (800479d
). Report is 7 commits behind head on main.
Thanks @nguyenv ! :)
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Changes:
Extracting readback of core domain, current domain, and non-empty domain are all currently:
libtiledbsoma
, templatized;pybind11
layer lke this https://github.com/single-cell-data/TileDB-SOMA/blob/b3feada0d1282442d1190f56a43670a32dad97ae/apis/python/src/tiledbsoma/soma_array.cc#L671-L830;The best option for Python/R interop is:
libtiledbsoma
nanoarrow
to interface with Python and RThe current PR simply moves some code currently used in
libtiledbsoma
's unit-test logic toArrowAdapter
, where it can -- and will -- be used for readback of core domain, current domain, and non-empty domain for #2407.Notes for Reviewer:
This is just a code-move. If all existing unit tests pass, that is success. No new unit tests are introduced here, since no new unit tests are needed.